linux-kernel - [PATCH] ARM: perf: ensure the cpu is available to scheduler when set irq affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1445414162-12414-1-git-send-email-roy.qing.li@gmail.com>
Date:	Wed, 21 Oct 2015 15:56:02 +0800
From:	roy.qing.li@...il.com
To:	linux-kernel@...r.kernel.org, will.deacon@....com
Subject: [PATCH] ARM: perf: ensure the cpu is available to scheduler when set irq affinity

From: Li RongQing <roy.qing.li@...il.com> 

when there are 4 cpus, but only one is available to schedule, the warning
will be generated when run the below command:
    # perf record -g -e cpu-clock -- find / -name "*.ko"
    CPU PMU: unable to set irq affinity (irq=28, cpu=1)
    CPU PMU: unable to set irq affinity (irq=29, cpu=2)
    CPU PMU: unable to set irq affinity (irq=30, cpu=3)

so ensure the cpu is available to scheduler when set irq affinity

Signed-off-by: Li RongQing <roy.qing.li@...il.com>
---
 drivers/perf/arm_pmu.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
index 2365a32..9401aa8 100644
--- a/drivers/perf/arm_pmu.c
+++ b/drivers/perf/arm_pmu.c
@@ -619,6 +619,9 @@ static void cpu_pmu_free_irq(struct arm_pmu *cpu_pmu)
 			if (cpu_pmu->irq_affinity)
 				cpu = cpu_pmu->irq_affinity[i];
 
+			if (!cpu_online(cpu))
+				continue;
+
 			if (!cpumask_test_and_clear_cpu(cpu, &cpu_pmu->active_irqs))
 				continue;
 			irq = platform_get_irq(pmu_device, i);
@@ -665,6 +668,9 @@ static int cpu_pmu_request_irq(struct arm_pmu *cpu_pmu, irq_handler_t handler)
 			if (cpu_pmu->irq_affinity)
 				cpu = cpu_pmu->irq_affinity[i];
 
+			if (!cpu_online(cpu))
+				continue;
+
 			/*
 			 * If we have a single PMU interrupt that we can't shift,
 			 * assume that we're running on a uniprocessor machine and
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/