linux-kernel - Re: [UPDATED] [PATCHv4 00/24] arm64: Consolidate CPU feature handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 21 Oct 2015 11:28:06 +0100
From:	Dave Martin <Dave.Martin@....com>
To:	"Suzuki K. Poulose" <suzuki.poulose@....com>
Cc:	linux-arm-kernel@...ts.infradead.org, mark.rutland@....com,
	Vladimir.Murzin@....com, steve.capper@...aro.org,
	ryan.arnold@...aro.org, ard.biesheuvel@...aro.org, aph@...hat.com,
	catalin.marinas@....com, will.deacon@....com,
	linux-kernel@...r.kernel.org, edward.nevill@...aro.org,
	james.morse@....com, andre.przywara@....com, marc.zyngier@....com,
	christoffer.dall@...aro.org
Subject: Re: [UPDATED] [PATCHv4 00/24] arm64: Consolidate CPU feature handling

On Mon, Oct 19, 2015 at 02:24:37PM +0100, Suzuki K. Poulose wrote:
> Resending the series with fixed mail ids.
> 
> ---
> This series introduces a new infrastructure to keep track of the CPU
> feature registers on ARMv8-A for arm64 kernel. It provides the safe value
> of a CPU feature register across all the CPUs on (a heterogeneous) system.
> The infrastructure checks the individual CPU feature registers as they are
> brought online (during system boot up) and udpates the status of each of
> the feature bits across the system. Once all the active CPUs are brought
> online (i.e, smp_cpus_done() ), the system can compute a reliable set of
> capabilities (arm64_features CPU capability and ELF HWCAP). This allows
> system to operate safely on CPUs with differing capabilities. Any new CPU
> brought up(hotplugged in) should have all the established capabilities,
> failing which could be disastrous. (e.g, alternative code patched in for
> a feature avaialble on the system). We add a hotplug notifier to check if
> the new CPU is missing any of the advertised capabilities and prevents it
> from turning online if it is.

[...]

For the series,

Tested-by: Dave Martin <Dave.Martin@....com>

(i.e., the system boots and MRS from userspace seems to do the correct
thing -- I haven't stressed the series.)

I don't propose to review the patch content in detail since other
people have already looked at it, the the code looks reasonable and
seems to work but I'll let you know if I spot anything.

Cheers
---Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/