linux-kernel - Re: [PATCH 10/19] ARM: dts: at91: replace gpio-key,wakeup with wakeup-source property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFq8CfzVPPCz=1AxZM3wsw8pkOPG6Ua_5spDuYa=Gzshrw@mail.gmail.com>
Date:	Wed, 21 Oct 2015 13:01:17 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Sudeep Holla <sudeep.holla@....com>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
Subject: Re: [PATCH 10/19] ARM: dts: at91: replace gpio-key,wakeup with
 wakeup-source property

On 21 October 2015 at 12:25, Sudeep Holla <sudeep.holla@....com> wrote:
>
>
> On 21/10/15 11:21, Nicolas Ferre wrote:
>>
>> Le 21/10/2015 12:10, Sudeep Holla a écrit :
>>>
>>> Though the keyboard driver for GPIO buttons(gpio-keys) will continue to
>>> check for/support the legacy "gpio-key,wakeup" boolean property to
>>> enable gpio buttons as wakeup source, "wakeup-source" is the new
>>> standard binding.
>>>
>>> This patch replaces the legacy "gpio-key,wakeup" with the unified
>>> "wakeup-source" property in order to avoid any futher copy-paste
>>> duplication.
>>>
>>> Cc: Nicolas Ferre <nicolas.ferre@...el.com>
>>
>>
>> I'm not against this if the whole series goes further.
>> Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>
>>
>
> Thanks !
>
>> I suspect that we would need to take this patch with us on the AT91
>> branches that would go to arm-soc. Is it the intentions?
>>
>
> Yes that was my intention for splitting the patches per SoC group.
> Many SoC maintainers prefer that.

Hold on! All patches that changes the DT parsing to accept the
"standardized wakeup-source" binding, need to be merged upstream
before corresponding DTS changes.

Therefore, I suggest we go for a two step approach, starting with
changes affecting the DT parsing/documentation for various
drivers/subsystem and perhaps we can reach 4.4 for these.
Then the DTS changes can go in at any later point.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/