lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <5626FD51.4090402@roeck-us.net> Date: Tue, 20 Oct 2015 19:49:53 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Huang Rui <ray.huang@....com> Cc: kbuild test robot <lkp@...el.com>, Yuanhan Liu <yuanhan.liu@...ux.intel.com>, Fengguang Wu <fengguang.wu@...el.com>, kbuild-all@...org, Borislav Petkov <bp@...e.de>, Peter Zijlstra <peterz@...radead.org>, Jean Delvare <jdelvare@...e.de>, Andy Lutomirski <luto@...capital.net>, Andreas Herrmann <herrmann.der.user@...il.com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...nel.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <lenb@...nel.org>, John Stultz <john.stultz@...aro.org>, Fr�d�ric Weisbecker <fweisbec@...il.com>, lm-sensors@...sensors.org, linux-kernel@...r.kernel.org, x86@...nel.org, Andreas Herrmann <herrmann.der.user@...glemail.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>, Borislav Petkov <bp@...en8.de>, Aaron Lu <aaron.lu@...el.com>, Tony Li <tony.li@....com> Subject: Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power On 10/20/2015 07:40 PM, Huang Rui wrote: > On Tue, Oct 20, 2015 at 07:15:25PM -0700, Guenter Roeck wrote: >> On 10/20/2015 06:42 PM, Huang Rui wrote: >>> On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: >>>> Hi Huang, >>>> >>>> [auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] >>>> >>>> url: https://github.com/0day-ci/linux/commits/Huang-Rui/hwmon-fam15h_power-Introduce-an-accumulated-power-reporting-algorithm/20151020-110712 >>>> config: x86_64-randconfig-s2-10201413 (attached as .config) >>>> reproduce: >>>> # save the attached .config to linux build tree >>>> make ARCH=x86_64 >>>> >>>> All errors (new ones prefixed by >>): >>>> >>>> drivers/built-in.o: In function `fam15h_power_probe': >>>>>> fam15h_power.c:(.text+0x26e3a3): undefined reference to `amd_get_cores_per_cu' >>>> fam15h_power.c:(.text+0x26e41e): undefined reference to `amd_get_cores_per_cu' >>>> >>> >>> Thanks to report this issue. :) >>> The root cause is that the test config doesn't enable >>> CONFIG_CPU_SUP_AMD. >>> >>> How about below fix: >>> >> >> Guess you don't have a choice. >> > > Yes, if I use test config, fam15h_power isn't chosen. :) > > And if I use the "select" flag like below, fam15h_power can be built > successfully. > That is another possibility, though that isn't how CPU_SUP_AMD is handled by its other users. Matter of philosophy, I guess. Guenter > --- > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index 796569ee..50b4fef 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -289,6 +289,7 @@ config SENSORS_K10TEMP > config SENSORS_FAM15H_POWER > tristate "AMD Family 15h processor power" > depends on X86 && PCI > + select CPU_SUP_AMD > help > If you say yes here you get support for processor power > information of your AMD family 15h CPU. > --- > > Thanks, > Rui > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists