linux-kernel - Re: [PATCH 1/3] staging: comedi: make ni_tio_has_gate2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5627C0D1.7060903@mev.co.uk>
Date:	Wed, 21 Oct 2015 17:44:01 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Geliang Tang <geliangtang@....com>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: comedi: make ni_tio_has_gate2_registers
 return boolean

On 18/10/15 15:35, Geliang Tang wrote:
> This patch makes ni_tio_has_gate2_registers return boolean, since
> this function only uses either one or zero as its return value.
>
> Signed-off-by: Geliang Tang <geliangtang@....com>
> ---
>   drivers/staging/comedi/drivers/ni_tio.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/staging/comedi/drivers/ni_tio.c
> index c20c51b..b74e44e 100644
> --- a/drivers/staging/comedi/drivers/ni_tio.c
> +++ b/drivers/staging/comedi/drivers/ni_tio.c
> @@ -167,15 +167,15 @@ static inline unsigned GI_HW_ARM_SEL_MASK(enum ni_gpct_variant variant)
>   	}
>   }
>
> -static int ni_tio_has_gate2_registers(const struct ni_gpct_device *counter_dev)
> +static bool ni_tio_has_gate2_registers(const struct ni_gpct_device *counter_dev)
>   {
>   	switch (counter_dev->variant) {
>   	case ni_gpct_variant_e_series:
>   	default:
> -		return 0;
> +		return false;
>   	case ni_gpct_variant_m_series:
>   	case ni_gpct_variant_660x:
> -		return 1;
> +		return true;
>   	}
>   }
>
>

Looks okay!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/