linux-kernel - Re: [PATCH 08/15] net: wireless: simplify return flow for usb_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXAfNJwZV7u9ZGF4p3--mz1gnLGnGVmcAJnq7o9H_jheD9r5w@mail.gmail.com>
Date:	Wed, 21 Oct 2015 23:35:06 +0530
From:	punit vara <punitvara@...il.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	Kalle Valo <kvalo@....qualcomm.com>, stas.yakovlev@...il.com,
	chaoming_li@...lsil.com.cn,
	Larry Finger <Larry.Finger@...inger.net>,
	Christian Lamparter <chunkeey@...glemail.com>,
	sgruszka@...hat.com, brudley@...adcom.com, arend@...adcom.com,
	John Linville <linville@...driver.com>,
	Nick Kossifidis <mickflemm@...il.com>, mcgrof@...not-panic.com,
	Eugene Krasnikov <k.eugene.e@...il.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	brcm80211-dev-list@...adcom.com, wcn36xx@...ts.infradead.org,
	johannes.berg@...el.com, meuleman@...adcom.com
Subject: Re: [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

On Wed, Oct 21, 2015 at 8:30 PM, Jiri Slaby <jslaby@...e.cz> wrote:
> On 10/21/2015, 04:55 PM, Punit Vara wrote:
>> @@ -544,13 +544,10 @@ static void at76_ledtrig_tx_activity(void)
>>  static int at76_remap(struct usb_device *udev)
>>  {
>>       int ret;
>> -     ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
>> +     return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
>>                             USB_TYPE_VENDOR | USB_DIR_OUT |
>>                             USB_RECIP_INTERFACE, 0, 0, NULL, 0,
>>                             USB_CTRL_GET_TIMEOUT);
>> -     if (ret < 0)
>> -             return ret;
>> -     return 0;
>
> ret is now unused, right?
>
> --
> js
> suse labs
Oppp..Sorry I have missed int ret to remove . I will resend the
updated patch soon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/