linux-kernel - Re: [RFC PATCH v6 3/3] arm: fix a migrating irq bug when hotplug cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Oct 2015 21:29:08 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Yang Yingliang <yangyingliang@...wei.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Marc Zyngier <marc.zyngier@....com>,
	Mark Rutland <mark.rutland@....com>,
	Will Deacon <will.deacon@....com>,
	Hanjun Guo <hanjun.guo@...aro.org>,
	Linux-sh list <linux-sh@...r.kernel.org>
Subject: Re: [RFC PATCH v6 3/3] arm: fix a migrating irq bug when hotplug cpu

On Wed, Oct 21, 2015 at 01:47:49PM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 24, 2015 at 11:32 AM, Yang Yingliang
> <yangyingliang@...wei.com> wrote:
> > When cpu is disabled, all irqs will be migratged to another cpu.
> > In some cases, a new affinity is different, the old affinity need
> > to be updated and if irq_set_affinity's return value is IRQ_SET_MASK_OK_DONE,
> > the old affinity can not be updated. Fix it by using irq_do_set_affinity.
> >
> > And migrating interrupts is a core code matter, so use the generic
> > function irq_migrate_all_off_this_cpu() to migrate interrupts in
> > kernel/irq/migration.c.
> >
> > Cc: Jiang Liu <jiang.liu@...ux.intel.com>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Marc Zyngier <marc.zyngier@....com>
> > Cc: Mark Rutland <mark.rutland@....com>
> > Cc: Will Deacon <will.deacon@....com>
> > Cc: Russell King - ARM Linux <linux@....linux.org.uk>
> > Cc: Hanjun Guo <hanjun.guo@...aro.org>
> > Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> > ---
> >  arch/arm/Kconfig           |  1 +
> >  arch/arm/include/asm/irq.h |  1 -
> >  arch/arm/kernel/irq.c      | 62 ----------------------------------------------
> >  arch/arm/kernel/smp.c      |  2 +-
> >  4 files changed, 2 insertions(+), 64 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 72ad724..bffba78 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -1492,6 +1492,7 @@ config NR_CPUS
> >  config HOTPLUG_CPU
> >         bool "Support for hot-pluggable CPUs"
> >         depends on SMP
> > +       select GENERIC_IRQ_MIGRATION
> 
> This causes the following warnings during s2ram on r8a7791/koelsch
> (dual-core CA15):

Thanks for the report.  I'll see what tonight's boot run says for my
platforms.  Hopefully, the author of these changes can help debug
this.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/