linux-kernel - [PATCH 4/4] staging: fbtft: fix voltage settings for C-Berry28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0650cce102019ef49c8264036134a44e65be9902.1445284543.git.menschel-d@posteo.de>
Date:	Wed, 21 Oct 2015 23:16:56 +0200
From:	Dennis Menschel <menschel-d@...teo.de>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Noralf Trønnes <noralf@...nnes.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Dennis Menschel <menschel-d@...teo.de>
Subject: [PATCH 4/4] staging: fbtft: fix voltage settings for C-Berry28

This patch fixes some internal voltage settings for the C-Berry28 display.
The original example source files for the C-Berry28 as provided by
its vendor admatec contained six issues where a command parameter's value
didn't match its corresponding comment.
I've informed admatec about these discrepancies on 2015-08-25. In the
meantime, I've assumed the comments to be more reliable than the code,
and thus have used these values to write the initial C-Berry28 driver.
After having received a reply from admatec on 2015-10-16 that the issues
have been fixed in their example code, it has turned out that for the
voltages VCOM and AVDD, the code was indeed correct, but the comments
were wrong. This patch is meant to fix these two pending mistakes.

Signed-off-by: Dennis Menschel <menschel-d@...teo.de>
---
 drivers/staging/fbtft/fbtft_device.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c
index d7475d7..071f79b 100644
--- a/drivers/staging/fbtft/fbtft_device.c
+++ b/drivers/staging/fbtft/fbtft_device.c
@@ -162,18 +162,18 @@ static int cberry28_init_sequence[] = {
 	/* VDV = 0V */
 	-1, 0xC4, 0x20,

-	/* VCOM = 0.875V */
-	-1, 0xBB, 0x1F,
+	/* VCOM = 0.675V */
+	-1, 0xBB, 0x17,

 	/* VCOM offset = 0V */
 	-1, 0xC5, 0x20,

 	/*
-	 * AVDD = 6.6V
+	 * AVDD = 6.8V
 	 * AVCL = -4.8V
 	 * VDS = 2.3V
 	 */
-	-1, 0xD0, 0xA4, 0x61,
+	-1, 0xD0, 0xA4, 0xA1,

 	-1, MIPI_DCS_SET_DISPLAY_ON,

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/