linux-kernel - Re: [PATCH] regulator, dt: add dt support for tps6502x regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56286B65.1010209@denx.de>
Date:	Thu, 22 Oct 2015 06:51:49 +0200
From:	Heiko Schocher <hs@...x.de>
To:	Mark Brown <broonie@...nel.org>
Cc:	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH] regulator, dt: add dt support for tps6502x regulator

Hello Mark,

Am 21.10.2015 um 18:17 schrieb Mark Brown:
> On Wed, Oct 21, 2015 at 02:52:51PM +0200, Heiko Schocher wrote:
>> Am 21.10.2015 um 14:19 schrieb Mark Brown:
>>> On Mon, Oct 19, 2015 at 08:27:13AM +0200, Heiko Schocher wrote:
>
>>> If this file is needed there is something broken, if this file is not
>>> needed then it is just noise since everything in it needs to be
>>> overridden by users anyway.  Either way please remove it.
>
>> Uh, I thought to do it like:
>
>> arch/arm/boot/dts/tps65217.dtsi
>
>> but, okay, removed.
>
> That too is broken and should be removed :(

Ok, I have a board which uses this regulator ... can you give me a hint,
how to remove it correctly?

I would do:

move from arch/arm/boot/dts/tps65217.dtsi into board dts

&tps {
+	compatible = "ti,tps65217";
	[...]

and the reg and "regulator-compatible" into the corresponding
nodes ...

                 dcdc1_reg: regulator@0 {
+                        reg = <0>;
+                        regulator-compatible = "dcdc1";

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/