linux-kernel - Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Oct 2015 09:54:18 +0300
From:	Eliad Peller <eliad@...ery.com>
To:	Punit Vara <punitvara@...il.com>
Cc:	Kalle Valo <kvalo@...eaurora.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, jslaby@...e.cz,
	lkp@...el.com
Subject: Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified
 for wl1271_cmd_interrogate

On Wed, Oct 21, 2015 at 10:07 PM, Punit Vara <punitvara@...il.com> wrote:
> Remove int ret suggested by kbuild test robot
>
> This patch is to the wlcore/acx.c file that fixes up warning
> reported by coccicheck:
>
> WARNING: end returns can be simplified if negative or 0 value
>
> Prefer direct return value instead of writing 2-3 more sentence.
>
> Signed-off-by: Punit Vara <punitvara@...il.com>
> ---
>  drivers/net/wireless/ti/wlcore/acx.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/ti/wlcore/acx.c b/drivers/net/wireless/ti/wlcore/acx.c
> index f28fa3b..6b566d9 100644
> --- a/drivers/net/wireless/ti/wlcore/acx.c
> +++ b/drivers/net/wireless/ti/wlcore/acx.c
> @@ -158,16 +158,11 @@ out:
>  int wl1271_acx_mem_map(struct wl1271 *wl, struct acx_header *mem_map,
>                        size_t len)
>  {
> -       int ret;
>
>         wl1271_debug(DEBUG_ACX, "acx mem map");
>
> -       ret = wl1271_cmd_interrogate(wl, ACX_MEM_MAP, mem_map,
> +       return wl1271_cmd_interrogate(wl, ACX_MEM_MAP, mem_map,
>                                      sizeof(struct acx_header), len);
> -       if (ret < 0)
> -               return ret;
> -
> -       return 0;
>  }
>
this changes the return value in case of positive values.
have you verified it can't happen / won't affect the code flow?
i'm not sure you really want to blindly patch it...

Eliad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/