linux-kernel - Re: [PATCH] leds: leds-wrap.c: Use devm_led_classdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <56288D13.3070108@samsung.com>
Date:	Thu, 22 Oct 2015 09:15:31 +0200
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Fida Mohammad <fmthoker@...il.com>
Cc:	Bryan Wu <cooloney@...il.com>, Richard Purdie <rpurdie@...ys.net>,
	linux-leds@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Muhammad Falak <falakreyaz@...il.com>,
	Kristian Kielhofner <kris@...sk.org>
Subject: Re: [PATCH] leds: leds-wrap.c: Use devm_led_classdev_register

Hi Fida,

On 10/21/2015 12:58 PM, Fida Mohammad wrote:
> Use of resource managed function devm_led_classdev_register to
> make initialization path simpler. Also removed redundant remove
> function.
>
> Signed-off-by: Fida Mohammad <fmthoker@...il.com>
> ---
>   drivers/leds/leds-wrap.c | 26 ++++----------------------
>   1 file changed, 4 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/leds/leds-wrap.c b/drivers/leds/leds-wrap.c
> index 1ba3def..c5ff4b4 100644
> --- a/drivers/leds/leds-wrap.c
> +++ b/drivers/leds/leds-wrap.c
> @@ -76,39 +76,21 @@ static int wrap_led_probe(struct platform_device *pdev)
>   {
>   	int ret;
>
> -	ret = led_classdev_register(&pdev->dev, &wrap_power_led);
> +	ret = devm_led_classdev_register(&pdev->dev, &wrap_power_led);
>   	if (ret < 0)
>   		return ret;
>
> -	ret = led_classdev_register(&pdev->dev, &wrap_error_led);
> +	ret = devm_led_classdev_register(&pdev->dev, &wrap_error_led);
>   	if (ret < 0)
> -		goto err1;
> -
> -	ret = led_classdev_register(&pdev->dev, &wrap_extra_led);
> -	if (ret < 0)
> -		goto err2;
> -
> -	return ret;
> +		return ret;
>
> -err2:
> -	led_classdev_unregister(&wrap_error_led);
> -err1:
> -	led_classdev_unregister(&wrap_power_led);
> +	return  devm_led_classdev_register(&pdev->dev, &wrap_extra_led);
>

Removed two extra empty lines end applied, thanks.

> -	return ret;
>   }
>
> -static int wrap_led_remove(struct platform_device *pdev)
> -{
> -	led_classdev_unregister(&wrap_power_led);
> -	led_classdev_unregister(&wrap_error_led);
> -	led_classdev_unregister(&wrap_extra_led);
> -	return 0;
> -}
>
>   static struct platform_driver wrap_led_driver = {
>   	.probe		= wrap_led_probe,
> -	.remove		= wrap_led_remove,
>   	.driver		= {
>   		.name		= DRVNAME,
>   	},
>


-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/