linux-kernel - Re: [PATCH] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DA4A1A39-64DA-4CB9-80B0-89E61D9AF779@linaro.org>
Date:	Thu, 22 Oct 2015 10:33:36 +0200
From:	Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:	Taku Izumi <izumi.taku@...fujitsu.com>
Cc:	linux-tip-commits@...r.kernel.org, linux-kernel@...r.kernel.org,
	mingo.kernel.org@...il.com, matt.fleming@...el.com,
	kamezawa.hiroyu@...fujitsu.com
Subject: Re: [PATCH] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds


> On 22 okt. 2015, at 19:28, Taku Izumi <izumi.taku@...fujitsu.com> wrote:
> 
> commit-0f96a99 introduces the following warning message:
> 
>  drivers/firmware/efi/fake_mem.c:186:20: warning: cast to pointer
>  from integer of different size [-Wint-to-pointer-cast]
> 
> new_memmap_phy was defined as a u64 value and casted to void*.
> This causes a warning of int-to-pointer-cast on x86 32-bit
> environment.
> 
> This patch changes the type of "new_memmap_phy" variable
> from "u64" into "phys_addr_t" to avoid it.

This assumes sizeof(void*) == sizeof(phys_addr_t), which is not always true, e.g., on 32-bit ARM (whose UEFI support is in development but not yet merged) with LPAE enabled.

Could we use unsigned long instead?

Ard.


> Reported-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Taku Izumi <izumi.taku@...fujitsu.com>
> ---
> drivers/firmware/efi/fake_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/efi/fake_mem.c b/drivers/firmware/efi/fake_mem.c
> index 32bcb14..b65bc07 100644
> --- a/drivers/firmware/efi/fake_mem.c
> +++ b/drivers/firmware/efi/fake_mem.c
> @@ -59,7 +59,7 @@ void __init efi_fake_memmap(void)
>    u64 start, end, m_start, m_end, m_attr;
>    int new_nr_map = memmap.nr_map;
>    efi_memory_desc_t *md;
> -    u64 new_memmap_phy;
> +    phys_addr_t new_memmap_phy;
>    void *new_memmap;
>    void *old, *new;
>    int i;
> -- 
> 1.8.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/