linux-kernel - Re: [PATCH v2 1/3] dt-bindings: Consolidate SRAM bindings from all vendors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151022090529.GV10947@lukather>
Date:	Thu, 22 Oct 2015 11:05:29 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Kukjin Kim <kgene@...nel.org>, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	Javier Martinez Canillas <javier@....samsung.com>,
	Heiko Stuebner <heiko@...ech.de>, Chen-Yu Tsai <wens@...e.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: Consolidate SRAM bindings from all
 vendors

Hi,

On Thu, Oct 22, 2015 at 10:25:28AM +0900, Krzysztof Kozlowski wrote:
> SRAM bindings for various SoCs, using the mmio-sram genalloc
> API, are spread over different places - per SoC vendor. Since all of
> these are quite similar (they depend on mmio-sram) move them to a common
> place.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Cc: Chen-Yu Tsai <wens@...e.org>
> Cc: Kukjin Kim <kgene@...nel.org>
> Suggested-by: Rob Herring <robh+dt@...nel.org>
> 
> ---
> 
> Changes since v1:
> 1. New patch. Extended suggestion from Rob.
> ---
>  .../bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt}    | 0
>  .../bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt}    | 0
>  .../bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt}         | 0
>  Documentation/devicetree/bindings/{misc => sram}/sram.txt                 | 0
>  .../devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt}       | 0
>  5 files changed, 0 insertions(+), 0 deletions(-)
>  rename Documentation/devicetree/bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt} (100%)
>  rename Documentation/devicetree/bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt} (100%)
>  rename Documentation/devicetree/bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt} (100%)
>  rename Documentation/devicetree/bindings/{misc => sram}/sram.txt (100%)
>  rename Documentation/devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt} (100%)

I'm not sure about that one. The SRAM bindins we have for sunxi is for
an SRAM controller, that maps the SRAM either to the CPU or to the
devices.

It's not really related to the other users, and wouldn't it be
confusing to have a driver in drivers/soc, and a Documentation in
another sub-directory?

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)