linux-kernel - Re: [PATCH] printk: Don't discard earlier unprinted messages to make space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1445509727.4113.52.camel@infradead.org>
Date:	Thu, 22 Oct 2015 11:28:47 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	David Howells <dhowells@...hat.com>, linux-kernel@...r.kernel.org
Cc:	jack@...e.cz, will.deacon@....com, rostedt@...dmis.org,
	pmladek@...e.cz
Subject: Re: [PATCH] printk: Don't discard earlier unprinted messages to
 make space

On Thu, 2015-10-22 at 11:16 +0100, David Howells wrote:
> printk() currently discards earlier messages to make space for new messages
> arriving.  This has the distinct downside that if the kernel starts
> churning out messages because of some initial incident, the report of the
> initial incident is likely to be lost under a blizzard of:
> 
>         ** NNN printk messages dropped **
> 
> messages from console_unlock().
> 
> The first message generated (typically an oops) is usually the most
> important - the one you want to solve first - so we really want to see
> that.

But wait... didn't I watch you muttering on IRC about the actual bug
you were trying to catch here... and didn't you have a *serial* console
hooked up?

What broke such that serial console stopped giving you *every* message?

Serial console was always *synchronous*.

We could do stuff like...

   printk("Going to do foo...\n");
   outb(foo, baz);
   printk("Did foo and the machine didn't catch fire! Now bar\n");
   outb(bar, baz);
   printk("Done\n");

And with a serial console I could know *precisely* the point at which
the machine locked up.

And I could enable the silly debugging levels on things like JFFS2 and
be sure that with a serial console I could catch *every* printk
reliably — which led to a number of cases where people would reproduce
a bug with a serial console and debugging, mail me a huge log file, and
get a patch back in reply.

We *need* to have a mode where serial console is actually *reliable*,
and we can know that the message has been sent out the port before the
printk() call returns.

What happened to it? And how do we fix it?

-- 
dwmw2

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5691 bytes)