linux-kernel - Re: [PATCHv12 14/37] futex, thp: remove special case for THP in get_futex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151022103344.GB29487@littlebeast.usersys.redhat.com>
Date:	Thu, 22 Oct 2015 12:33:44 +0200
From:	Artem Savkov <artem.savkov@...il.com>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
Cc:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Hugh Dickins <hughd@...gle.com>,
	Dave Hansen <dave.hansen@...el.com>,
	Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
	Vlastimil Babka <vbabka@...e.cz>,
	Christoph Lameter <cl@...two.org>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Steve Capper <steve.capper@...aro.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Michal Hocko <mhocko@...e.cz>,
	Jerome Marchand <jmarchan@...hat.com>,
	Sasha Levin <sasha.levin@...cle.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCHv12 14/37] futex, thp: remove special case for THP in
 get_futex_key

On Thu, Oct 22, 2015 at 12:49:45PM +0300, Kirill A. Shutemov wrote:
> On Thu, Oct 22, 2015 at 10:24:33AM +0200, Artem Savkov wrote:
> > On Tue, Oct 06, 2015 at 06:23:41PM +0300, Kirill A. Shutemov wrote:
> > > With new THP refcounting, we don't need tricks to stabilize huge page.
> > > If we've got reference to tail page, it can't split under us.
> > > 
> > > This patch effectively reverts a5b338f2b0b1.
> > > 
> > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > > Tested-by: Sasha Levin <sasha.levin@...cle.com>
> > > Tested-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
> > > Acked-by: Jerome Marchand <jmarchan@...hat.com>
> > > ---
> > >  kernel/futex.c | 61 ++++++++++++----------------------------------------------
> > >  1 file changed, 12 insertions(+), 49 deletions(-)
> > 
> > This patch breaks compound page futexes with the following panic:
>
> Thanks for report. Patch below fixes the issue for me.
> Could you test it as well?
> 
Yep, this patch does fix the problem for me as well.

-- 
Regards,
  Artem
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/