linux-kernel - Re: [PATCH 0/3] Refactor nested mdiobus read/write functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151022131831.GG1985@lunn.ch>
Date:	Thu, 22 Oct 2015 15:18:31 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Neil Armstrong <narmstrong@...libre.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	vivien.didelot@...oirfairelinux.com,
	Fabian Frederick <fabf@...net.be>,
	Pavel Nakonechny <pavel.nakonechny@...tlab.ru>,
	Joe Perches <joe@...ches.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, nbd@...nwrt.org,
	sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH 0/3] Refactor nested mdiobus read/write functions

On Thu, Oct 22, 2015 at 10:37:45AM +0200, Neil Armstrong wrote:
> In order to avoid locked signal false positive for nested mdiobus
> read/write calls, nested code was introduced in mv88e6xxx and
> mdio-mux.
> But mv88e6060 also needs such nested mdiobus read/write calls.
> For sake of refactoring, introduce nested variants of mdiobus read/write
> and make them used by mv88e6xxx and mv88e6060.
> In a next patch, mdio-mux should also use these variant calls.
> 
> Neil Armstrong (3):
>   net: phy: Add nested variants of mdiobus read/write
>   net: dsa: Make mv88e6xxx use nested mdiobus read/write
>   net: dsa: Make mv88e6060 use nested mdiobus read/write
> 
>  drivers/net/dsa/mv88e6060.c |  4 ++--
>  drivers/net/dsa/mv88e6xxx.c | 46 ++++++++-----------------------------
>  drivers/net/phy/mdio_bus.c  | 55 +++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/phy.h         |  2 ++
>  4 files changed, 68 insertions(+), 39 deletions(-)

Hi Neil

Thanks for refactoring.

Reviewd-by: Andrew Lunn <andrew@...n.ch>
Tested-by: Andrew Lunn <andrew@...n.ch>

I tested with a 88E6172 and lockdep enabled.

Thanks
  Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/