linux-kernel - Re: [PATCH block/for-linus] blkcg: fix incorrect read/write sync/async stat accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <x49lhavgetk.fsf@segfault.boston.devel.redhat.com>
Date:	Thu, 22 Oct 2015 10:25:59 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Jens Axboe <axboe@...nel.dk>, Vivek Goyal <vgoyal@...hat.com>,
	linux-kernel@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH block/for-linus] blkcg: fix incorrect read/write sync/async stat accounting

Tejun Heo <tj@...nel.org> writes:

> While unifying how blkcg stats are collected, 77ea733884eb ("blkcg:
> move io_service_bytes and io_serviced stats into blkcg_gq")
> incorrectly used bio->flags instead of bio->rw to tell the IO type.
> This made IOs to be accounted as the wrong type.  Fix it.
>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Fixes: 77ea733884eb ("blkcg: move io_service_bytes and io_serviced stats into blkcg_gq")

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>

> ---
>  include/linux/blk-cgroup.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/include/linux/blk-cgroup.h
> +++ b/include/linux/blk-cgroup.h
> @@ -713,9 +713,9 @@ static inline bool blkcg_bio_issue_check
>  
>  	if (!throtl) {
>  		blkg = blkg ?: q->root_blkg;
> -		blkg_rwstat_add(&blkg->stat_bytes, bio->bi_flags,
> +		blkg_rwstat_add(&blkg->stat_bytes, bio->bi_rw,
>  				bio->bi_iter.bi_size);
> -		blkg_rwstat_add(&blkg->stat_ios, bio->bi_flags, 1);
> +		blkg_rwstat_add(&blkg->stat_ios, bio->bi_rw, 1);
>  	}
>  
>  	rcu_read_unlock();
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/