lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151022014126.GA5624@shlinux2> Date: Thu, 22 Oct 2015 09:41:28 +0800 From: Peter Chen <peter.chen@...escale.com> To: <eu@...ipetonello.com> CC: <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, Felipe Balbi <balbi@...com>, Andrzej Pietrasiewicz <andrzej.p@...sung.com> Subject: Re: [PATCH 2/3] usb: chipidea: udc: improve error handling on ep_queue On Fri, Sep 18, 2015 at 06:30:20PM +0100, eu@...ipetonello.com wrote: > From: "Felipe F. Tonello" <eu@...ipetonello.com> > > _ep_queue() didn't check for errors when using add_td_to_list() > which can fail if dma_pool_alloc fails, thus causing a kernel > panic when lastnode->ptr is NULL. > > Signed-off-by: Felipe F. Tonello <eu@...ipetonello.com> > --- > > Changes for v2: > - Use separate patch for cleanups. > > drivers/usb/chipidea/udc.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c > index c936c72..7169113e 100644 > --- a/drivers/usb/chipidea/udc.c > +++ b/drivers/usb/chipidea/udc.c > @@ -435,19 +435,27 @@ static int _hardware_enqueue(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq) > if (hwreq->req.dma % PAGE_SIZE) > pages--; > > - if (rest == 0) > - add_td_to_list(hwep, hwreq, 0); > + if (rest == 0) { > + ret = add_td_to_list(hwep, hwreq, 0); > + if (ret < 0) > + goto done; > + } > > while (rest > 0) { > unsigned count = min(hwreq->req.length - hwreq->req.actual, > (unsigned)(pages * CI_HDRC_PAGE_SIZE)); > - add_td_to_list(hwep, hwreq, count); > + ret = add_td_to_list(hwep, hwreq, count); > + if (ret < 0) > + goto done; > rest -= count; > } > > if (hwreq->req.zero && hwreq->req.length > - && (hwreq->req.length % hwep->ep.maxpacket == 0)) > - add_td_to_list(hwep, hwreq, 0); > + && (hwreq->req.length % hwep->ep.maxpacket == 0)) { > + ret = add_td_to_list(hwep, hwreq, 0); > + if (ret < 0) > + goto done; > + } > > firstnode = list_first_entry(&hwreq->tds, struct td_node, td); > > -- > 2.1.4 > Hi Felipe, I can't apply it in my tree, would you please create it based on chipdea tree? https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git branch: ci-for-usb-next -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists