linux-kernel - Re: [PATCH] pstore: fix return type of pstore_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Oct 2015 09:30:36 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Geliang Tang <geliangtang@....com>
Cc:	Anton Vorontsov <anton@...msg.org>,
	Colin Cross <ccross@...roid.com>,
	Tony Luck <tony.luck@...el.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pstore: fix return type of pstore_is_mounted

On Thu, Oct 22, 2015 at 1:02 AM, Geliang Tang <geliangtang@....com> wrote:
> This patch changes return type of pstore_is_mounted from int to bool.
>
> Signed-off-by: Geliang Tang <geliangtang@....com>

Sure! :)

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  fs/pstore/inode.c    | 2 +-
>  fs/pstore/internal.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c
> index 3586491..d8c439d 100644
> --- a/fs/pstore/inode.c
> +++ b/fs/pstore/inode.c
> @@ -288,7 +288,7 @@ static const struct super_operations pstore_ops = {
>
>  static struct super_block *pstore_sb;
>
> -int pstore_is_mounted(void)
> +bool pstore_is_mounted(void)
>  {
>         return pstore_sb != NULL;
>  }
> diff --git a/fs/pstore/internal.h b/fs/pstore/internal.h
> index 96253c4..e38a22b 100644
> --- a/fs/pstore/internal.h
> +++ b/fs/pstore/internal.h
> @@ -63,6 +63,6 @@ extern int    pstore_mkfile(enum pstore_type_id, char *psname, u64 id,
>                               int count, char *data, bool compressed,
>                               size_t size, struct timespec time,
>                               struct pstore_info *psi);
> -extern int     pstore_is_mounted(void);
> +extern bool    pstore_is_mounted(void);
>
>  #endif
> --
> 1.9.1
>
>



-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/