linux-kernel - Re: [RFC] fpga: socfpga: Fix check of return value of devm_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Oct 2015 14:24:03 -0500
From:	atull <atull@...nsource.altera.com>
To:	Moritz Fischer <moritz.fischer@...us.com>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [RFC] fpga: socfpga: Fix check of return value of
 devm_request_irq

On Thu, 22 Oct 2015, Moritz Fischer wrote:

Hi Moritz,

Thank you, yes this is better.

I don't know if I need to ack everything, but here it is
anyway:

Acked-by: Alan Tull <atull@...nsource.altera.com>

Alan

> The return value should be checked for non-zero, instead
> of checking it being IS_ERR_VALUE().
> 
> Signed-off-by: Moritz Fischer <moritz.fischer@...us.com>
> ---
>  drivers/fpga/socfpga.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c
> index 706b80d..27d2ff2 100644
> --- a/drivers/fpga/socfpga.c
> +++ b/drivers/fpga/socfpga.c
> @@ -577,7 +577,7 @@ static int socfpga_fpga_probe(struct platform_device *pdev)
>  
>  	ret = devm_request_irq(dev, priv->irq, socfpga_fpga_isr, 0,
>  			       dev_name(dev), priv);
> -	if (IS_ERR_VALUE(ret))
> +	if (ret)
>  		return ret;
>  
>  	return fpga_mgr_register(dev, "Altera SOCFPGA FPGA Manager",
> -- 
> 2.4.3
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/