linux-kernel - Re: [PATCH] staging: lustre: o2iblnd: fix misleading indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151022194819.GR7340@mwanda>
Date:	Thu, 22 Oct 2015 22:48:19 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	andreas.dilger@...el.com, gulsah.1004@...il.com,
	gregkh@...uxfoundation.org, shuey@...due.edu,
	oleg.drokin@...el.com, yejiayily@...il.com,
	guillaume.matheron@....fr, lustre-devel@...ts.lustre.org,
	amir.shehata@...el.com, he.huang@...el.com
Subject: Re: [PATCH] staging: lustre: o2iblnd: fix misleading indentation

On Wed, Oct 21, 2015 at 06:40:40PM +0100, Luis de Bethencourt wrote:
> The code is correct, the indentation is misleading. Only the the return rc
> is part of the conditional statement if rc != 0.
> 
> Fix a smatch warning:
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2157
> kiblnd_hdev_setup_mrs() warn: curly braces intended?
> 
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
> 
> Hi,
> 
> This patch gives a warning in checkpatch.pl for the line:
> if (hdev->ibh_mrs == NULL)
> 
> It would be cleaner if this was 'if (!hdev->ibh_mrs)' instead. I didn't fix
> this as well because the file has 41 instances of comparisons with NULL. I
> would be happy to do so in a patch in reply to this one if it would be good.
> 

You did the right thing.  One thing per patch.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/