linux-kernel - Re: [PATCH 1/3] i2c: uniphier: add UniPhier FIFO-less I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Oct 2015 22:59:09 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	linux-i2c@...r.kernel.org,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Anders Berg <anders.berg@...gotech.com>,
	Max Schwarz <max.schwarz@...ine.de>,
	David Box <david.e.box@...ux.intel.com>,
	Wei Yan <sledge.yanwei@...wei.com>,
	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
	Andrew Bresticker <abrestic@...omium.org>,
	linux-kernel@...r.kernel.org, Kamal Dasu <kdasu.kdev@...il.com>,
	Laurentiu Palcu <laurentiu.palcu@...el.com>,
	Baruch Siach <baruch@...s.co.il>,
	Xudong Chen <xudong.chen@...iatek.com>,
	Lee Jones <lee.jones@...aro.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Neelesh Gupta <neelegup@...ux.vnet.ibm.com>,
	Sachin Kamat <sachin.kamat@...sung.com>,
	Ray Jui <rjui@...adcom.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] i2c: uniphier: add UniPhier FIFO-less I2C driver

On Thu, Jul 30, 2015 at 05:12:20PM +0900, Masahiro Yamada wrote:
> Add support for on-chip I2C controller used on old UniPhier SoCs
> such as PH1-LD4, PH1-sLD8, etc..  This adapter is so simple that
> it has no FIFO in it.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Finally! Mostly looking good.

> +static u32 uniphier_i2c_functionality(struct i2c_adapter *adap)
> +{
> +	return I2C_FUNC_I2C;
> +}

No I2C_FUNC_SMBUS_EMUL? But check if SMBUS_QUICK is supported by your
adapter.

> +	regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!regs) {
> +		dev_err(dev, "failed to get memory resource");
> +		return -EINVAL;
> +	}

This 'if'-block can go. devm_ioremap_resource will check it for you.

Thanks,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)