linux-kernel - Re: [PATCH V5 1/1] usb:serial add Fintek F81532/534 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56284916.1010903@gmail.com>
Date:	Thu, 22 Oct 2015 10:25:26 +0800
From:	Peter Hung <hpeter@...il.com>
To:	Johan Hovold <johan@...nel.org>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, tom_tsai@...tek.com.tw,
	peter_hong@...tek.com.tw,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH V5 1/1] usb:serial add Fintek F81532/534 driver

Hi Johan,

Johan Hovold 於 2015/9/14 下午 09:33 寫道:
> On Tue, Jul 21, 2015 at 09:58:19AM +0800, Peter Hung wrote:

>>        4. RS422 Mode
>>           1. The RTS mode is dont care.
>>           2. Set M2/M1/M0 as 0/0/0
>
> I don't think all gpios should be exported for these ports if they have
> special functions that the driver could control transparently (e.g. for
> SER_RS485_RTS_ON_SEND).

Surely, we can hide some setting with definitely setting like
RS232/RS485, but the settings is only apply to our evaluation board.

Some customers will use our F81532/534 with other brand transceiver IC.
The pins setting maybe changed, so we decided to separate UART & pins
settings and let the 3 output pins controllable for customer.

Could I preserve currently UART & pins setting mode ?

>> +	current_mode &= BIT(gpio_num);
>> +
>> +	mutex_unlock(&serial_priv->change_mode_mutex);
>> +	f81534_wakeup_all_port(port->serial);
>> +
>> +	return !!current_mode;
>> +}
>
> Your gpio implementation looks wrong, but let's get back to that after
> you explain how these pins are used.
>
> If they are not really general purpose pins, then this isn't the right
> interface.

The 4x3 pins is output-only mode to control transceiver, so I'm only
implement the output functions and let all input functions failed.

Could you give some advices to me if the gpiolib interface cant be
used ?

Sorry for late reply, I'm almost ready to submit v6 when clarify some
questions.

Thanks,
-- 
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/