linux-kernel - Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific device tree binding document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151022124449.GH8232@sirena.org.uk>
Date:	Thu, 22 Oct 2015 13:44:49 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	lee.jones@...aro.org, cw00.choi@...sung.com,
	myungjoo.ham@...sung.com, lgirdwood@...il.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific device
 tree binding document

On Thu, Oct 15, 2015 at 02:47:07PM +0100, Charles Keepax wrote:

> +This document lists regulator specific bindings, see the primary binding
> +document:
> +  ../mfd/arizona.txt
> +
> +Required properties:
> +
> +  - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
> +    as covered in regulator.txt
> +
> +  - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
> +    wm5110, wm8280, wm8998, wm1814)
> +
> +  - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
> +    wm5110, wm8280, wm8998, wm1814)
> +
> +  - SPKVDD-supply : Speaker driver power supply (wm8997)
> +

I'd expect these to be on the MFD since they're (with the exception of
AVDD which supplies the regulators IIRC) not part of the regulator
component of the device and are core for bringing it online.

> +Optional properties:
> +  - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
> +
> +Optional subnodes:
> +  - ldo1 : Initial data for the LDO1 regulator, as covered in
> +    Documentation/devicetree/bindings/regulator/regulator.txt
> +  - micvdd : Initial data for the MICVDD regulator, as covered in
> +    Documentation/devicetree/bindings/regulator/regulator.txt

These are the properties for the regulator itself.

> +++ b/MAINTAINERS
> @@ -11381,6 +11381,7 @@ W:	http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-devices
>  S:	Supported
>  F:	Documentation/hwmon/wm83??
>  F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> +F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
>  F:	arch/arm/mach-s3c64xx/mach-crag6410*
>  F:	drivers/clk/clk-wm83*.c
>  F:	drivers/extcon/extcon-arizona.c

I'd suggest moving this to a separate patch which adds all the new files
together to make it easier to merge things.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)