linux-kernel - Re: [PATCH v2 3/3] ASoC: cs47l24: Add driver for Cirrus Logic CS47L24 and WM1831 codecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151022124057.GG8232@sirena.org.uk>
Date:	Thu, 22 Oct 2015 13:40:57 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:	lee.jones@...aro.org, linus.walleij@...aro.org,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH v2 3/3] ASoC: cs47l24: Add driver for Cirrus Logic
 CS47L24 and WM1831 codecs

On Mon, Oct 19, 2015 at 03:13:47PM +0100, Richard Fitzgerald wrote:

> @@ -134,6 +134,7 @@ config SND_SOC_ALL_CODECS
>  	select SND_SOC_WM5100 if I2C
>  	select SND_SOC_WM5102 if MFD_WM5102
>  	select SND_SOC_WM5110 if MFD_WM5110
> +	select SND_SOC_CS47L24 if MFD_CS47L24
>  	select SND_SOC_WM8350 if MFD_WM8350
>  	select SND_SOC_WM8400 if MFD_WM8400
>  	select SND_SOC_WM8510 if SND_SOC_I2C_AND_SPI

Please keep the Makefile and Kconfig sorted.

> +config SND_SOC_CS47L24
> +	tristate "TEST cs47l24"
> +

This isn't a good help text for the symbol.

Otherwise the code looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)