linux-kernel - Re: [PATCH v2 2/3] Documentation: DT bindings: rockchip-i2s: add capture property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151022165017.GA8232@sirena.org.uk>
Date:	Fri, 23 Oct 2015 01:50:17 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Sugar Zhang <sugar.zhang@...k-chips.com>
Cc:	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
	heiko@...ech.de, alsa-devel@...a-project.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] Documentation: DT bindings: rockchip-i2s: add
 capture property

On Thu, Oct 08, 2015 at 08:40:08PM +0800, Sugar Zhang wrote:

> +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
> @@ -21,6 +21,7 @@ Required properties:
>  - clock-names: should contain followings:
>     - "i2s_hclk": clock for I2S BUS
>     - "i2s_clk" : clock for I2S controller
> +- rockchip,capture-channels: max capture channels, if not set, 2 channels default.

If this can not be set then it's an optional property, not a required
property, and should be in the optional properties section.  Please send
a followup patch fixing that.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)