linux-kernel - RE: [PATCH 2/2] can: xilinx: fix bug in bus error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C246CAC1457055469EF09E3A7AC4E11A4A4F3593@XAP-PVEXMBX01.xlnx.xilinx.com>
Date:	Fri, 23 Oct 2015 05:21:58 +0000
From:	Appana Durga Kedareswara Rao <appana.durga.rao@...inx.com>
To:	Soren Brinkmann <sorenb@...inx.com>
CC:	Anirudha Sarangi <anirudh@...inx.com>,
	"wg@...ndegger.com" <wg@...ndegger.com>,
	"mkl@...gutronix.de" <mkl@...gutronix.de>,
	Michal Simek <michals@...inx.com>,
	"linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] can: xilinx: fix bug in bus error handling

Hi Soren,

> -----Original Message-----
> From: Sören Brinkmann [mailto:soren.brinkmann@...inx.com]
> Sent: Thursday, October 22, 2015 10:03 PM
> To: Appana Durga Kedareswara Rao
> Cc: Anirudha Sarangi; wg@...ndegger.com; mkl@...gutronix.de; Michal
> Simek; Appana Durga Kedareswara Rao; linux-can@...r.kernel.org;
> netdev@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH 2/2] can: xilinx: fix bug in bus error handling
> 
> On Thu, 2015-10-22 at 10:16AM +0530, Kedareswara rao Appana wrote:
> > Simply resetting the peripheral on bus off condition is not enough,
> > Because we also need to re-initialize the whole device.
> > This patch fixes this issue.
> >
> > Signed-off-by: Kedareswara rao Appana <appanad@...inx.com>
> > ---
> >  drivers/net/can/xilinx_can.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/can/xilinx_can.c
> > b/drivers/net/can/xilinx_can.c index 055d6f3..9aeb85f 100644
> > --- a/drivers/net/can/xilinx_can.c
> > +++ b/drivers/net/can/xilinx_can.c
> > @@ -529,6 +529,8 @@ static int xcan_rx(struct net_device *ndev)
> >  	return 1;
> >  }
> >
> > +static void xcan_chip_stop(struct net_device *ndev);
> 
> Isn't it possible to move the function and avoid the forward declaration?

Yes it is possible to move the function will fix it in the next version of the patch.

Regards,
Kedar.

> 
> 	Sören