linux-kernel - Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151023064558.GZ7289@mwanda>
Date:	Fri, 23 Oct 2015 09:45:58 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Nilesh Kokane <nilesh.kokane05@...il.com>
Cc:	oleg.drokin@...el.com, andreas.dilger@...el.com,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, suneel.raikar@...il.com
Subject: Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno
 should typically be negative (ie: return -EAGAIN)

On Fri, Oct 23, 2015 at 08:00:09AM +0300, Dan Carpenter wrote:
> On Fri, Oct 23, 2015 at 10:00:03AM +0530, Nilesh Kokane wrote:
> > Fixed- Return of an errno should typically be negative (ie: return -EAGAIN)
> > 
> 
> The changelog needs to describe the use visible effects of this change.
> 

I was expecting you to respond to my email saying that you had seen the
mistake...  Anyway, bugs like this are why the process requires that
user visible changes need documentation.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/