linux-kernel - Re: [PATCH] serial: amba-pl011: fix incorrect integer size in pl011_fifo_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZNv-Q3-0KntE4k1dLWHn30H5POpmEaOWKiWCsuPMtjFw@mail.gmail.com>
Date:	Fri, 23 Oct 2015 12:04:48 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Timur Tabi <timur@...eaurora.org>
Cc:	Greg Kroah-Hartman <greg@...ah.com>,
	Russell King <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: amba-pl011: fix incorrect integer size in pl011_fifo_to_tty()

On Wed, Oct 7, 2015 at 10:27 PM, Timur Tabi <timur@...eaurora.org> wrote:

> The UART_DUMMY_DR_RX status bit is equal to (1 << 16), so a u16 is too small
> to hold that value.  The result is that UART_DUMMY_DR_RX is never passed
> to uart_insert_char().  This means that we're always accepting characters,
> even when CREAD (in termios) is not set.
>
> Signed-off-by: Timur Tabi <timur@...eaurora.org>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/