linux-kernel - Re: [PATCH 2/3] i2c: uniphier_f: add UniPhier FIFO-builtin I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATNazGG74DYvPXPUf5WE6K4356OzJnbxv4DuKjGC_g+kw@mail.gmail.com>
Date:	Fri, 23 Oct 2015 19:59:54 +0900
From:	Masahiro Yamada <yamada.masahiro@...ionext.com>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	linux-i2c@...r.kernel.org,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Anders Berg <anders.berg@...gotech.com>,
	Xudong Chen <xudong.chen@...iatek.com>,
	Andrew Bresticker <abrestic@...omium.org>,
	David Box <david.e.box@...ux.intel.com>,
	Laurentiu Palcu <laurentiu.palcu@...el.com>,
	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
	Kamal Dasu <kdasu.kdev@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Beniamino Galvani <b.galvani@...il.com>,
	Lee Jones <lee.jones@...aro.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Neelesh Gupta <neelegup@...ux.vnet.ibm.com>,
	Sachin Kamat <sachin.kamat@...sung.com>,
	Ray Jui <rjui@...adcom.com>,
	Subhendu Sekhar Behera <sbehera@...adcom.com>
Subject: Re: [PATCH 2/3] i2c: uniphier_f: add UniPhier FIFO-builtin I2C driver

2015-10-23 6:06 GMT+09:00 Wolfram Sang <wsa@...-dreams.de>:
> On Thu, Jul 30, 2015 at 05:12:21PM +0900, Masahiro Yamada wrote:
>> Add support for on-chip I2C controller used on newer UniPhier SoCs
>> such as PH1-Pro4, PH1-Pro5, etc.  This adapter is equipped with
>> 8-depth TX/RX FIFOs.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>
> Same comments as for the other driver.

Fixed in v2.

> And quite some debug messages left. Could you check if you still want
> them or if they were mostly useful during development of the driver?

Yes, I want to keep them.  I do not think they are too much.


I will probably come back to these drivers when I find some time
in order to implement further features such as the slave mode.   :)

dev_dbg() might be useful for the new development
as well as for checking something when hardware went wrong for some reason.


-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/