[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151023124812.GA4588@lst.de>
Date: Fri, 23 Oct 2015 14:48:12 +0200
From: Christoph Hellwig <hch@....de>
To: Daniel Baluta <daniel.baluta@...el.com>
Cc: jic23@...nel.org, jlbec@...lplan.org, linux-iio@...r.kernel.org,
linux-fsdevel@...r.kernel.org, lars@...afoo.de, hch@....de,
knaack.h@....de, linux-kernel@...r.kernel.org,
octavian.purdila@...el.com, pebolle@...cali.nl,
patrick.porlan@...el.com, adriana.reus@...el.com,
constantin.musca@...el.com, marten@...uitiveaerial.com,
cristina.opriceana@...il.com, pmeerw@...erw.net,
viro@...iv.linux.org.uk, akpm@...ux-foundation.org
Subject: Re: [PATCH v9 1/5] configfs: Allow dynamic group creation
Hi Daniel,
all these functions look great, but can you also move your new
iio_sw_trigger_type_configfs_register/unregister functions to the
core code as those are the wrappers that everyone would have to write,
e.g. something like:
int configfs_register_default_group(struct config_group *parent_group,
const char *name, struct config_item_type *item_type)
{
struct config_group *group;
group = kzalloc(sizeof(*group), GFP_KERNEL);
if (!group)
return -ENOMEM;
config_group_init_type_name(group, name, item_type);
ret = configfs_register_group(parent_group, group);
if (ret)
kfree(group);
return ret;
}
and the same on the unregister side?
With that:
Reviewed-by: Christoph Hellwig <hch@....de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists