linux-kernel - Re: [PATCH v9 1/5] configfs: Allow dynamic group creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZAMpOZyByT+gd3FjmmtPHubvr=EREZ1peJF310VyX1U1w@mail.gmail.com>
Date:	Fri, 23 Oct 2015 17:09:47 +0300
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Christoph Hellwig <hch@....de>
Cc:	Daniel Baluta <daniel.baluta@...el.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Joel Becker <jlbec@...lplan.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org,
	Lars-Peter Clausen <lars@...afoo.de>,
	Hartmut Knaack <knaack.h@....de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"octavian.purdila@...el.com" <octavian.purdila@...el.com>,
	Paul Bolle <pebolle@...cali.nl>, patrick.porlan@...el.com,
	Adriana Reus <adriana.reus@...el.com>,
	constantin.musca@...el.com, marten@...uitiveaerial.com,
	Cristina Georgiana Opriceana <cristina.opriceana@...il.com>,
	Peter Meerwald <pmeerw@...erw.net>, viro@...iv.linux.org.uk,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v9 1/5] configfs: Allow dynamic group creation

Christoph, one question. See below.

On Fri, Oct 23, 2015 at 3:48 PM, Christoph Hellwig <hch@....de> wrote:
> Hi Daniel,
>
> all these functions look great, but can you also move your new
> iio_sw_trigger_type_configfs_register/unregister functions to the
> core code as those are the wrappers that everyone would have to write,
> e.g. something like:
>
> int configfs_register_default_group(struct config_group *parent_group,
>                 const char *name, struct config_item_type *item_type)
> {
>         struct config_group *group;
>
>         group = kzalloc(sizeof(*group), GFP_KERNEL);
>         if (!group)
>                 return -ENOMEM;
>         config_group_init_type_name(group, name, item_type);

Until this point this is the implementation of configfs_alloc_group.

We have two options:

1) Remove configfs_alloc_group/configfs_free_group as people will directly
use our new configfs_register_default_group that does the allocation.

2) Keep configfs_alloc/group/configfs_gree_group and use it here.

I'm in favour of 1) variant, as it makes little sense to have a wrapper over
kmalloc + config_group_init_type_name.

thanks,
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/