linux-kernel - Re: [PATCH] ARM: dts: am335x-boneblack: Use pinctrl constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <562A45DC.1090501@ti.com>
Date:	Fri, 23 Oct 2015 09:36:12 -0500
From:	"Andrew F. Davis" <afd@...com>
To:	Javier Martinez Canillas <javier@...hile0.org>
CC:	Tony Lindgren <tony@...mide.com>,
	Benoît Cousson <bcousson@...libre.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: am335x-boneblack: Use pinctrl constants

On 10/23/2015 09:29 AM, Javier Martinez Canillas wrote:
> Hello Andrew,
>
> On Fri, Oct 23, 2015 at 3:08 PM, Andrew F. Davis <afd@...com> wrote:
>> On 10/22/2015 04:23 PM, Tony Lindgren wrote:
>>>
>>> * Andrew F. Davis <afd@...com> [151022 09:21]:
>>>>
>>>> Using constants for pinctrl allows better readability and removes
>>>> redundancy with comments.
>>>
>>>
>>> You should use the include/dt-bindings/pinctrl/omap.h macro
>>> AM33XX_IOPAD(pa, val) while at it. Otherwise we'll end up patching
>>> the same things again later on.
>>>
>>
>> Hmm, I haven't really been following this change, it kind of seems to add
>> some unnecessary abstraction by using physical hardware addresses instead
>> of offsets, then just converting them back to offsets. The offset style DT
>> nodes are already auto-generated with existing tools anyway:
>> https://dev.ti.com/pinmux
>>
>> I'm sure this has been discussed already so if this is a blocker I'll
>> re-spin this.
>>
>
> The good thing about the IOPAD pinmux macros is that matches what is
> in the TRM so it is easier to read the DTS and verify that is correct.
>
> I've on my queue to migrate all the remaining DTS for TI SoCs to use
> the IOPAD macros but is just that I didn't have time to do it this
> week. Probably I'll do it at the end of the next week.
>

Then this patch can probably be dropped, hopefully the converted constants
in this patch can be of some help for you though.

Andrew

>> Andrew
>>
>>
>>> Regards,
>>>
>
> Best regards,
> Javier
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/