linux-kernel - Re: [RFC] hwmon: ina2xx: port to using remap, improve bandwidth.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201510240048.uw9je8jf%fengguang.wu@intel.com>
Date:	Sat, 24 Oct 2015 00:55:14 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Marc Titinger <mtitinger@...libre.com>
Cc:	kbuild-all@...org, linux@...ck-us.net, jdelvare@...e.com,
	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org,
	mturquette@...libre.com, bcousson@...libre.com,
	Marc Titinger <mtitinger@...libre.com>
Subject: Re: [RFC] hwmon: ina2xx: port to using remap, improve bandwidth.

Hi Marc,

[auto build test WARNING on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Marc-Titinger/hwmon-ina2xx-port-to-using-remap-improve-bandwidth/20151024-001809
config: xtensa-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

   drivers/hwmon/ina2xx.c: In function 'ina2xx_probe':
>> drivers/hwmon/ina2xx.c:456:3: warning: format '%li' expects argument of type 'long int', but argument 3 has type 'u32' [-Wformat=]
      dev_err(dev, "Invalid shunt resistor value %li", val);
      ^

vim +456 drivers/hwmon/ina2xx.c

   440		/* Set config according to device type. */
   441		data->config = &ina2xx_config[id->driver_data];
   442		data->client = client;
   443	
   444		/* Check for shunt resistor value.
   445		 * Give precedence to device tree over must-recompile.
   446		 */
   447		if (of_property_read_u32(dev->of_node, "shunt-resistor", &val) < 0) {
   448			pdata = dev_get_platdata(dev);
   449			if (pdata)
   450				val = pdata->shunt_uohms;
   451			else
   452				val = INA2XX_RSHUNT_DEFAULT;
   453		}
   454	
   455		if (val <= 0 || val > data->config->calibration_factor) {
 > 456			dev_err(dev, "Invalid shunt resistor value %li", val);
   457			return -ENODEV;
   458		}
   459		data->rshunt = val;
   460	
   461		/* Write config to chip, and calibrate */
   462		ret = ina2xx_init(data);
   463		if (ret) {
   464			dev_err(dev, "error configuring the device.\n");

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (42415 bytes)