linux-kernel - [PATCH 2/2] scsi: remove useless casting value returned by kmalloc to structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1445630633-14209-3-git-send-email-punitvara@gmail.com>
Date:	Sat, 24 Oct 2015 01:33:53 +0530
From:	Punit Vara <punitvara@...il.com>
To:	JBottomley@...n.com
Cc:	don.brace@...s.com, storagedev@...s.com, iss_storagedev@...com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Punit Vara <punitvara@...il.com>
Subject: [PATCH 2/2] scsi: remove useless casting value returned by kmalloc to structure

This is the patch to the hpsa.c file that resolves following warning
reported by coccicheck:

WARNING: casting value returned by memory allocation function to
(BIG_IOCTL_Command_struct *) is useless.

Signed-off-by: Punit Vara <punitvara@...il.com>
---
 drivers/scsi/hpsa.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 40669f8..8d971b3 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -6027,8 +6027,7 @@ static int hpsa_big_passthru_ioctl(struct ctlr_info *h, void __user *argp)
 		return -EINVAL;
 	if (!capable(CAP_SYS_RAWIO))
 		return -EPERM;
-	ioc = (BIG_IOCTL_Command_struct *)
-	    kmalloc(sizeof(*ioc), GFP_KERNEL);
+	ioc = kmalloc(sizeof(*ioc), GFP_KERNEL);
 	if (!ioc) {
 		status = -ENOMEM;
 		goto cleanup1;
-- 
2.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/