linux-kernel - Re: [PATCH v12 4/6] QE/CPM: move muram management functions to qe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1445633780.701.228.camel@freescale.com>
Date:	Fri, 23 Oct 2015 15:56:20 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Zhao Qiang-B45475 <qiang.zhao@...escale.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"lauraa@...eaurora.org" <lauraa@...eaurora.org>,
	Xie Xiaobo-R63061 <X.Xie@...escale.com>,
	"benh@...nel.crashing.org" <benh@...nel.crashing.org>,
	Li Yang-Leo-R58472 <LeoLi@...escale.com>,
	"paulus@...ba.org" <paulus@...ba.org>
Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to
 qe_common

On Fri, 2015-10-23 at 02:45 -0500, Zhao Qiang-B45475 wrote:
> On Fri, 2015-10-23 at 11:10 AM, Wood Scott-B07421 <scottwood@...escale.com> 
> wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, October 23, 2015 11:10 AM
> > To: Zhao Qiang-B45475 <qiang.zhao@...escale.com>
> > Cc: linux-kernel@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org;
> > lauraa@...eaurora.org; Xie Xiaobo-R63061 <X.Xie@...escale.com>;
> > benh@...nel.crashing.org; Li Yang-Leo-R58472 <LeoLi@...escale.com>;
> > paulus@...ba.org
> > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to
> > qe_common
> > 
> > On Wed, 2015-10-14 at 15:16 +0800, Zhao Qiang wrote:
> > > QE and CPM have the same muram, they use the same management
> > > functions. Now QE support both ARM and PowerPC, it is necessary to
> > > move QE to "driver/soc", so move the muram management functions from
> > > cpm_common to qe_common for preparing to move QE code to "driver/soc"
> > > 
> > > Signed-off-by: Zhao Qiang <qiang.zhao@...escale.com>
> > > ---
> > > Changes for v2:
> > >       - no changes
> > > Changes for v3:
> > >       - no changes
> > > Changes for v4:
> > >       - no changes
> > > Changes for v5:
> > >       - no changes
> > > Changes for v6:
> > >       - using genalloc instead rheap to manage QE MURAM
> > >       - remove qe_reset from platform file, using
> > >       - subsys_initcall to call qe_init function.
> > > Changes for v7:
> > >       - move this patch from 3/3 to 2/3
> > >       - convert cpm with genalloc
> > >       - check for gen_pool allocation failure Changes for v8:
> > >       - rebase
> > >       - move BD_SC_* macro instead of copy Changes for v9:
> > >       - doesn't modify CPM, add a new patch to modify.
> > >       - rebase
> > > Changes for v10:
> > >       - rebase
> > > Changes for v11:
> > >       - remove renaming
> > >       - delete removing qe_reset and delete adding qe_init.
> > > Changes for v12:
> > >       - SPI_FSL_CPM depends on QE-MURAM, select QUICC_ENGINE for it.
> > 
> > Why is the SPI change part of this patch?  Why is it even part of this 
> > patchset,
> > rather than an independent patch sent to the SPI list and maintainer?  If 
> > it's tied
> > to other changes you're making, explain that.  As is, there is zero 
> > mention of
> > the SPI change in the part of the e-mail that will become the git 
> > changelog.
> > 
> This SPI_FSL_CPM is cpm-spi, it is part of CPM.

So then why are you selecting QUICC_ENGINE?  And again, what does it have to 
do with this patch?

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/