linux-kernel - Re: [PATCH v11 02/14] HMM: add special swap filetype for memory migrated to device v2.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151023035409.GA4404@gmail.com>
Date:	Thu, 22 Oct 2015 23:54:10 -0400
From:	Jerome Glisse <j.glisse@...il.com>
To:	Hillf Danton <hillf.zj@...baba-inc.com>
Cc:	'Jerome Glisse' <jglisse@...hat.com>, linux-mm@...ck.org,
	'linux-kernel' <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v11 02/14] HMM: add special swap filetype for memory
 migrated to device v2.

On Fri, Oct 23, 2015 at 11:23:26AM +0800, Hillf Danton wrote:
> > > > +	if (cnt_hmm_entry) {
> > > > +		int ret;
> > > > +
> > > > +		ret = hmm_mm_fork(src_mm, dst_mm, dst_vma,
> > > > +				  dst_pmd, start, end);
> > >
> > > Given start, s/end/addr/, no?
> > 
> > No, end is the right upper limit here.
> > 
> Then in the first loop, hmm_mm_fork is invoked for
> the _entire_ range, from input addr to end.
> In subsequent loops(if necessary), start is updated to
> addr, and hmm_mm_fork is also invoked for remaining
> range, from start to end.
> 
> Is the above overlap in range making sense?

Well yes and no, hmm_mm_fork() will do nothing for address >= addr
i feel like end is easier to understand.

Cheers,
Jérôme
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/