linux-kernel - RE: [PATCH] GHES: Fix cached error-status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F32B5DE60@ORSMSX114.amr.corp.intel.com>
Date:	Fri, 23 Oct 2015 23:05:15 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Davidlohr Bueso <dave@...olabs.net>,
	"Huang, Ying" <ying.huang@...el.com>
CC:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Borislav Petkov <bp@...e.de>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] GHES: Fix cached error-status

> ping?

I'm not actually sure that the code is wrong.  As you say it is a pretty strange loop.

We seem to want to look at a bunch of conditions, and use "continue" to ignore
bits until we find one that we like the look of.  Perhaps as soon as we do, we want
to believe it to get our return value? Perhaps the code knows that we won't find
another section that matches all the tests, so it isn't worth going around the loop
again.

Ying: You wrote this code 4 years ago. Any recollections of why it looks like it does?

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/