linux-kernel - Re: [RFC PATCH 4/7] perf tools: Enable BPF object configure syntax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5629BC29.9070601@huawei.com>
Date:	Fri, 23 Oct 2015 12:48:41 +0800
From:	"Wangnan (F)" <wangnan0@...wei.com>
To:	<acme@...nel.org>, <ast@...mgrid.com>, <brendan.d.gregg@...il.com>
CC:	<a.p.zijlstra@...llo.nl>, <daniel@...earbox.net>,
	<dsahern@...il.com>, <hekuang@...wei.com>, <jolsa@...nel.org>,
	<lizefan@...wei.com>, <masami.hiramatsu.pt@...achi.com>,
	<namhyung@...nel.org>, <paulus@...ba.org>,
	<linux-kernel@...r.kernel.org>, <pi3orama@....com>,
	<xiakaixu@...wei.com>, Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [RFC PATCH 4/7] perf tools: Enable BPF object configure syntax



On 2015/10/17 18:48, Wang Nan wrote:

[SNIP]
>   
>   event_bpf_file:
> -PE_BPF_OBJECT
> +PE_BPF_OBJECT event_bpf_config
>   {
>   	struct parse_events_evlist *data = _data;
>   	struct parse_events_error *error = data->error;
>   	struct list_head *list;
>   
>   	ALLOC_LIST(list);
> -	ABORT_ON(parse_events_load_bpf(data, list, $1, false));
> +	ABORT_ON(parse_events_load_bpf(data, list, $1, false, $2));
> +	parse_events__free_terms($2);

Here found a bug that $2 is possible to be NULL, but parse_events_free_terms
can't accept NULL param.

Will be fixed in next version.

Thank you.

>   	$$ = list;
>   }
>   |
> -PE_BPF_SOURCE
> +PE_BPF_SOURCE event_bpf_config
>   {
>   	struct parse_events_evlist *data = _data;
>   	struct list_head *list;
>   
>   	ALLOC_LIST(list);
> -	ABORT_ON(parse_events_load_bpf(data, list, $1, true));
> +	ABORT_ON(parse_events_load_bpf(data, list, $1, true, $2));
> +	parse_events__free_terms($2);
>   	$$ = list;
>   }
>   
> +event_bpf_config:
> +'/' event_config '/'
> +{
> +	$$ = $2;
> +}
> +|
> +{
> +	$$ = NULL;
> +}
> +
>   start_terms: event_config
>   {
>   	struct parse_events_terms *data = _data;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/