lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20151024.072405.1054520777247556344.davem@davemloft.net> Date: Sat, 24 Oct 2015 07:24:05 -0700 (PDT) From: David Miller <davem@...emloft.net> To: mans@...sr.com Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH v2 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller From: Mans Rullgard <mans@...sr.com> Date: Thu, 22 Oct 2015 17:28:50 +0100 > +static void nb8800_mac_tx(struct net_device *dev, int enable) ... > +static void nb8800_mac_rx(struct net_device *dev, int enable) ... > +static void nb8800_mac_af(struct net_device *dev, int enable) Please use 'bool' and true/false for 'enable'. > +static int nb8800_alloc_rx(struct net_device *dev, int i, int napi) Likewise here for 'napi'. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists