lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <562B9955.40308@ti.com> Date: Sat, 24 Oct 2015 09:44:37 -0500 From: Nishanth Menon <nm@...com> To: Tero Kristo <t-kristo@...com>, <a.zummo@...ertech.it>, <alexandre.belloni@...e-electrons.com> CC: <linux-kernel@...r.kernel.org>, <rtc-linux@...glegroups.com>, <linux-arm-kernel@...ts.infradead.org>, <linux-omap@...r.kernel.org> Subject: Re: [PATCH] rtc: ds1307: Fix alarm programming for mcp794xx On 10/23/2015 01:29 AM, Tero Kristo wrote: > mcp794xx alarm registers must be written in BCD format. However, the > alarm programming logic neglected this by adding one to the value > after bin2bcd conversion has been already done, writing bad values > to month register in case the alarm being set is in October. In this > case, the alarm month value becomes 0x0a instead of the expected 0x10. > > Fix by moving the +1 addition within the bin2bcd call also. > > Fixes: 1d1945d261a2 ("drivers/rtc/rtc-ds1307.c: add alarm support for mcp7941x chips") > > Signed-off-by: Tero Kristo <t-kristo@...com> Nice catch. Acked-by: Nishanth Menon <nm@...com> > --- > drivers/rtc/rtc-ds1307.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c > index a705e64..188006c 100644 > --- a/drivers/rtc/rtc-ds1307.c > +++ b/drivers/rtc/rtc-ds1307.c > @@ -718,9 +718,9 @@ static int mcp794xx_set_alarm(struct device *dev, struct rtc_wkalrm *t) > regs[3] = bin2bcd(t->time.tm_sec); > regs[4] = bin2bcd(t->time.tm_min); > regs[5] = bin2bcd(t->time.tm_hour); > - regs[6] = bin2bcd(t->time.tm_wday) + 1; > + regs[6] = bin2bcd(t->time.tm_wday + 1); > regs[7] = bin2bcd(t->time.tm_mday); > - regs[8] = bin2bcd(t->time.tm_mon) + 1; > + regs[8] = bin2bcd(t->time.tm_mon + 1); > > /* Clear the alarm 0 interrupt flag. */ > regs[6] &= ~MCP794XX_BIT_ALMX_IF; > -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists