linux-kernel - Re: [PATCH] serial: 8250_early: do not save and restore IER in write callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQa_M13UM2ruLuSGroOnejmJw3Fd2-fDgD2eJxm=F5Y=g@mail.gmail.com>
Date:	Sat, 24 Oct 2015 13:02:11 +0900
From:	Masahiro Yamada <yamada.masahiro@...ionext.com>
To:	Peter Hurley <peter@...leysoftware.com>
Cc:	linux-serial@...r.kernel.org,
	Vineet Gupta <Vineet.Gupta1@...opsys.com>,
	Kevin Cernekee <cernekee@...il.com>,
	Jiri Slaby <jslaby@...e.com>, Rob Herring <robh@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Eddie Huang <eddie.huang@...iatek.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] serial: 8250_early: do not save and restore IER in write callback

Hi Peter,

2015-10-23 21:45 GMT+09:00 Peter Hurley <peter@...leysoftware.com>:
> On 10/22/2015 04:21 AM, Masahiro Yamada wrote:
>> The IER has already been masked in early_serial8250_setup(), there is
>> no reason to save and restore it every time early_serial8250_write()
>> is called.
>>
>> Let wait_for_xmitr() melt into serial_putc().
>
> Both of these changes are ok with me, but please split this into
> 2 patches so reverting either one in case of regression is trivial.
>
> Regards,
> Peter Hurley


OK, will do.


-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/