lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151024104749.179dab64@OPI2> Date: Sat, 24 Oct 2015 10:47:49 +0200 From: Jean-Francois Moine <moinejf@...e.fr> To: Maxime Ripard <maxime.ripard@...e-electrons.com> Cc: Jens Kuske <jenskuske@...il.com>, devicetree@...r.kernel.org, Vishnu Patekar <vishnupatekar0510@...il.com>, Emilio López <emilio@...pez.com.ar>, Michael Turquette <mturquette@...libre.com>, linux-sunxi@...glegroups.com, linux-kernel@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>, Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh+dt@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, Linus Walleij <linus.walleij@...aro.org>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI On Sat, 24 Oct 2015 09:13:28 +0200 Maxime Ripard <maxime.ripard@...e-electrons.com> wrote: > Or simply > > bus_gates { > clocks = <&ahb1>, <&ahb2>; > clock-indices = <5>, <6>, <8>, ... > clock-output-names = "bus_ce", "bus_dma", "bus_mmc0" > }; I don't understand: the apb1, apb2, ahb1 and ahb2 clocks may be programmed independently to different frequencies and you have to know which of them is the parent of each leaf clock. So, either you hard-code the parents as Jens did in a first proposal, or you define the full list of parents in the DT as in the last proposal, or you use a container per parent in the DT as I proposed. There could be an other solution using the output clock name to define the parent clock: bus_gates { clocks = <&ahb1>, <&ahb2>, <&apb1>, <&apb2>; clock-indices = <5>, <6>, <8>, ... clock-output-names = "ahb1_ce", "ahb1_dma", "ahb1_mmc0" }; with the documentation: "the clocks MUST be defined in order: ahb1, ahb2, apb1, apb2." and the code if (strncmp(clock_name, "ahb1", 4) == 0) clk_parent = of_clk_get_parent_name(node, 0); else if (..) but it seems a bit hacky. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists