linux-kernel - Re: [PATCHv3 1/6] integrity: define '.evm' as a builtin 'trusted' keyring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151024091016.GA10998@localhost>
Date:	Sat, 24 Oct 2015 12:35:49 +0300
From:	Petko Manolov <petkan@...-labs.com>
To:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc:	Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
	linux-ima-devel@...ts.sourceforge.net,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Dmitry Kasatkin <dmitry.kasatkin@...wei.com>
Subject: Re: [PATCHv3 1/6] integrity: define '.evm' as a builtin 'trusted'
 keyring

On 15-10-23 14:43:53, Mimi Zohar wrote:
> On Fri, 2015-10-23 at 16:05 +0300, Petko Manolov wrote:
> > On 15-10-22 21:49:25, Dmitry Kasatkin wrote:
> 
> > > diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig
> > > index df30334..a292b88 100644
> > > --- a/security/integrity/ima/Kconfig
> > > +++ b/security/integrity/ima/Kconfig
> > > @@ -123,14 +123,17 @@ config IMA_APPRAISE
> > >  	  If unsure, say N.
> > >  
> > >  config IMA_TRUSTED_KEYRING
> > > -	bool "Require all keys on the .ima keyring be signed"
> > > +	bool "Require all keys on the .ima keyring be signed (deprecated)"
> > >  	depends on IMA_APPRAISE && SYSTEM_TRUSTED_KEYRING
> > >  	depends on INTEGRITY_ASYMMETRIC_KEYS
> > > +	select INTEGRITY_TRUSTED_KEYRING
> > >  	default y
> > >  	help
> > >  	   This option requires that all keys added to the .ima
> > >  	   keyring be signed by a key on the system trusted keyring.
> > >  
> > > +	   This option is deprecated in favor of INTEGRITY_TRUSTED_KEYRING
> > > +
> > >  config IMA_LOAD_X509
> > >  	bool "Load X509 certificate onto the '.ima' trusted keyring"
> > >  	depends on IMA_TRUSTED_KEYRING
> > 
> > 
> > I guess we may as well remove this switch.  Otherwise somebody have to remember 
> > to post a patch that does so a few kernel releases after this one goes mainline.
> 
> There's no harm in leaving the "IMA_TRUSTED_KEYRING" Kconfig option for a 
> couple of releases (or perhaps until it is enabled in a long term release), so 
> that the INTEGRITY_TRUSTED_KEYRING Kconfig option is enabled automatically.

I have no strong opinion either way.  Just saying.  Let it be for the moment.


		Petko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/