linux-kernel - CONFIG_CGROUP_WRITEBACK=y/n complexity (was: Re: Build regressions/improvements in v4.3-rc7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUcbE20kH7-gZ4i8978Smf7K3QYDwzRVRQoL3nOMYpurw@mail.gmail.com>
Date:	Sun, 25 Oct 2015 11:54:38 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Tejun Heo <tj@...nel.org>, Jens Axboe <axboe@...com>,
	Jan Kara <jack@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Linux MMC List <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: CONFIG_CGROUP_WRITEBACK=y/n complexity (was: Re: Build
 regressions/improvements in v4.3-rc7)

On Sun, Oct 25, 2015 at 11:12 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> Below is the list of build error/warning regressions/improvements in
> v4.3-rc7[1] compared to v4.2[2].
>
> Summarized:
>   - build errors: +13/-8
>   - build warnings: +160/-100
>
> JFYI, when comparing v4.3-rc7[1] to v4.3-rc6[3], the summaries are:
>   - build errors: +12/-4
>   - build warnings: +42/-40

> [1] http://kisskb.ellerman.id.au/kisskb/head/9511/ (256 out of 254 configs)
> [2] http://kisskb.ellerman.id.au/kisskb/head/9309/ (all 254 configs)
> [3] http://kisskb.ellerman.id.au/kisskb/head/9487/ (255 out of 254 configs)

> *** WARNINGS ***
>
> 160 regressions:

>   + /home/kisskb/slave/src/mm/page-writeback.c: warning: 'filepages' is used uninitialized in this function:  => 1582, 1908
>   + /home/kisskb/slave/src/mm/page-writeback.c: warning: 'headroom' is used uninitialized in this function:  => 1582, 1908

Please refactor this code. It falls under the "so complicated that there are
no obvious deficiencies " category
(https://en.wikiquote.org/wiki/C._A._R._Hoare).

Thanks a lot!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/