linux-kernel - Re: [PATCH 19/57] perf tools: Add attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151025122715.GA26211@krava.brq.redhat.com>
Date:	Sun, 25 Oct 2015 13:27:15 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	"Liang, Kan" <kan.liang@...el.com>
Subject: Re: [PATCH 19/57] perf tools: Add attr_update event

On Thu, Oct 22, 2015 at 10:01:46AM +0200, Jiri Olsa wrote:
> On Mon, Oct 19, 2015 at 06:00:04PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Oct 16, 2015 at 12:40:54PM +0200, Jiri Olsa escreveu:
> > > It'll server as base event for additional event attributes
> > > details, that are not part of the attr event.
> > > 
> > > At the moment this event is just dummy one without specific
> > > functionality. The type value will distinguish the update
> > > event details. It comes in following patches.
> > > 
> > > The idea for this event is to be extensible for any update
> > > that attr event might need in the future.
> > 
> > "Update"? Found it confusing, how about calling it "add event
> > attribute", because that is what this is doing, adding attributes, like
> > "unit" (Joules, MiB, nsec, etc), "scale", etc.
> 
> well, we have PERF_RECORD_HEADER_ATTR event based on which the
> event is created.. so PERF_RECORD_HEADER_ATTR_UPDATE seemed
> like good choice.. anyway, how about:
> 
>   PERF_RECORD_ADD_EVENT_ATTR
>   PERF_RECORD_EVENT_ATTR
>   PERF_RECORD_EVENT_UPDATE

choosing the PERF_RECORD_EVENT_UPDATE for next version..

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/