| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151025152637.GA1399@redhat.com> Date: Sun, 25 Oct 2015 16:26:37 +0100 From: Oleg Nesterov <oleg@...hat.com> To: Andrew Morton <akpm@...ux-foundation.org>, Markus Pargmann <mpa@...gutronix.de> Cc: nbd-general@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: [PATCH -mm 1/3] nbd: nbd_thread_send: remove the unnecessary kernel_dequeue_signal() nbd_thread_send() does kernel_dequeue_signal() at the end for no reason, it is fine to exit with the pending SIGKILL. Not sure it really needs another kernel_dequeue_signal() inside the main loop, we know that signal_pending() means SIGKILL. But probably we want to clear TIF_SIGPENDING before sock_shutdown(). Signed-off-by: Oleg Nesterov <oleg@...hat.com> --- drivers/block/nbd.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index b85e7a0..e5d96e5 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -586,10 +586,6 @@ static int nbd_thread_send(void *data) nbd->task_send = NULL; spin_unlock_irqrestore(&nbd->tasks_lock, flags); - /* Clear maybe pending signals */ - if (signal_pending(current)) - kernel_dequeue_signal(NULL); - return 0; } -- 1.5.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists