linux-kernel - Re: [PATCH 1/2] input: misc: e3x0-button: Fix typo in module name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151025204923.GA23656@dtor-pixel>
Date:	Sun, 25 Oct 2015 13:49:23 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Moritz Fischer <moritz.fischer@...us.com>
Cc:	jaewon02.kim@...sung.com, k.kozlowski@...sung.com, dmurphy@...com,
	geert@...ux-m68k.org, courtney.cavin@...ymobile.com,
	carlo@...one.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] input: misc: e3x0-button: Fix typo in module name

Hi Moritz,

On Sun, Oct 25, 2015 at 01:06:06PM -0700, Moritz Fischer wrote:
> The produced module will be called e3x0-button, not
> e3x0_button.

This is not entirely correct. The file name is e3x0-button.ko, but the
module name is e3x0_button: when we construct KBUILD_MODNAME we
substitute commas and dashes for underscores - see scripts/Makefile.lib

> 
> Signed-off-by: Moritz Fischer <moritz.fischer@...us.com>
> ---
>  drivers/input/misc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 906dd1b..7ac277c7 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -101,7 +101,7 @@ config INPUT_E3X0_BUTTON
>  	  USRP E3x0 Button.
>  
>  	  To compile this driver as a module, choose M here: the
> -	  module will be called e3x0_button.
> +	  module will be called e3x0-button.
>  
>  config INPUT_PCSPKR
>  	tristate "PC Speaker support"
> -- 
> 2.6.2
> 

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/