linux-kernel - Re: [PATCH V2] USB: usbtmc: Add support for missing USBTMC-USB488 spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151025025233.GB25874@kroah.com>
Date:	Sat, 24 Oct 2015 19:52:33 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	dave penkler <dpenkler@...il.com>
Cc:	peter.chen@...escale.com, teuniz@...il.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] USB: usbtmc: Add support for missing USBTMC-USB488
 spec

On Mon, Oct 19, 2015 at 09:33:20AM +0200, dave penkler wrote:
> 
> Implement support for the USB488 defined READ_STATUS_BYTE and SRQ
> notifications with ioctl, fasync and poll/select in order to be able
> to synchronize with variable duration instrument operations.
> 
> Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and
> LOCAL_LOCKOUT.
> 
> Add convenience ioctl to return all device capabilities.

Can you break this up into a series of patches, all doing only one
thing?  You are doing a lot of different things in this single patch,
making it almost impossible to review :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/