| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151025090423.GD24337@gmail.com> Date: Sun, 25 Oct 2015 10:04:23 +0100 From: Ingo Molnar <mingo@...nel.org> To: Namhyung Kim <namhyung@...nel.org> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Jiri Olsa <jolsa@...hat.com>, LKML <linux-kernel@...r.kernel.org>, David Ahern <dsahern@...il.com> Subject: Re: [PATCH 3/4] perf tools: Setup pager when printing usage and help * Namhyung Kim <namhyung@...nel.org> wrote: > It's annoying to see error or help message when command has many options like in > perf record, report or top. [...] That's indeed so. > [...] So setup pager when print parser error or help message - it should be OK > since no UI is enabled at the parsing time. The usage_with_options() already > disables it by calling exit_browser() anyway. So I wanted to write that this has a disadvantage as well, that the pager disrupts the regular 'timeline', 'append-only' visual flow of a regular shell workflow. But then I tried your patches, and for short outputs (such as 'perf stat -h') the pager is not activated, while for longer output (such as 'perf report -h') it's activated. That's very intuitive: Acked-by: Ingo Molnar <mingo@...nel.org> Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists